Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes based batching for traces #12519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for traces.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa requested review from bogdandrutu, dmitryax and a team as code owners February 27, 2025 18:48
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 91.76471% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.99%. Comparing base (beb9002) to head (032b69d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pdata/ptrace/pb.go 0.00% 6 Missing ⚠️
exporter/exporterhelper/traces_batch.go 98.07% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12519      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.02%     
==========================================
  Files         469      470       +1     
  Lines       25355    25397      +42     
==========================================
+ Hits        23327    23363      +36     
- Misses       1619     1625       +6     
  Partials      409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa
Copy link
Contributor Author

My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.

Ok. Please let me know if I can help with this somehow. I will very likely start working on the PRs for the other signals as well and adapt whatever is needed if there is a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants